dongjoon-hyun commented on a change in pull request #25220: [SPARK-28459][SQL] Add `make_timestamp` function URL: https://github.com/apache/spark/pull/25220#discussion_r308008348
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ########## @@ -1657,3 +1657,146 @@ case class MakeDate(year: Expression, month: Expression, day: Expression) override def prettyName: String = "make_date" } + +// scalastyle:off line.size.limit +@ExpressionDescription( + usage = "_FUNC_(year, month, day, hour, min, sec, timezone) - Create timestamp from year, month, day, hour, min, sec and timezone fields.", Review comment: We had better use the exact syntax to show the optionality. ```scala - usage = "_FUNC_(year, month, day, hour, min, sec, timezone) - Create timestamp from year, month, day, hour, min, sec and timezone fields.", + usage = "_FUNC_(year, month, day, hour, min, sec[, timezone]) - Create timestamp from year, month, day, hour, min, sec and timezone fields.", ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
