Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/4066#discussion_r23108302
--- Diff: core/src/main/scala/org/apache/spark/SparkHadoopWriter.scala ---
@@ -105,10 +107,20 @@ class SparkHadoopWriter(@transient jobConf: JobConf)
def commit() {
val taCtxt = getTaskContext()
val cmtr = getOutputCommitter()
+ val dagSchedulerActor =
+ AkkaUtils.makeDriverRef("DAGScheduler", SparkEnv.get.conf,
SparkEnv.get.actorSystem)
+ val askTimeout = AkkaUtils.askTimeout(SparkEnv.get.conf)
if (cmtr.needsTaskCommit(taCtxt)) {
try {
- cmtr.commitTask(taCtxt)
- logInfo (taID + ": Committed")
+ val canCommit: Boolean = AkkaUtils.askWithReply(
+ AskPermissionToCommitOutput(jobID, splitID, attemptID),
dagSchedulerActor, askTimeout)
--- End diff --
Whether or not such an extra layer of complexity and coordination is
necessary... it would be good before we merge this patch (or some version of
it) to run a benchmarking suite against it. Even though this is only affecting
hadoop-writing result tasks, it's on a critical path and we need a good
understanding of the performance implications.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
