cloud-fan commented on a change in pull request #21599: [SPARK-26218][SQL]
Overflow on arithmetic operations returns incorrect result
URL: https://github.com/apache/spark/pull/21599#discussion_r308732635
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
##########
@@ -228,6 +229,12 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
if (decimalVal.eq(null)) {
longVal / POW_10(_scale)
} else {
+ if (SQLConf.get.arithmeticOperationOverflowCheck) {
Review comment:
And we need to handle more cases as well, e.g. long to int, int to byte,
etc. AFAIK @gengliangwang is working on cast recently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
