cloud-fan commented on a change in pull request #21599: [SPARK-26218][SQL]
Overflow on arithmetic operations returns incorrect result
URL: https://github.com/apache/spark/pull/21599#discussion_r308737167
##########
File path: sql/core/src/test/resources/sql-tests/inputs/pgSQL/int4.sql
##########
@@ -33,6 +33,10 @@ INSERT INTO INT4_TBL VALUES ('-2147483647');
-- INSERT INTO INT4_TBL(f1) VALUES ('123 5');
-- INSERT INTO INT4_TBL(f1) VALUES ('');
+-- We cannot test this when checkOverflow=true here
+-- because exception happens in the executors and the
+-- output stacktrace cannot have an exact match
+set spark.sql.arithmetic.checkOverflow=false;
Review comment:
is it necessary? It's false by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
