cloud-fan commented on a change in pull request #21599: [SPARK-26218][SQL]
Overflow on arithmetic operations returns incorrect result
URL: https://github.com/apache/spark/pull/21599#discussion_r308733794
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
##########
@@ -359,6 +359,26 @@ trait ExpressionEvalHelper extends
GeneratorDrivenPropertyChecks with PlanTestBa
}
}
+ /**
+ * Test evaluation results between Interpreted mode and Codegen mode, making
sure we have
+ * consistent result regardless of the evaluation method we use. If an
exception is thrown,
+ * it checks that both modes throw the same exception.
+ *
+ * This method test against binary expressions by feeding them arbitrary
literals of `dataType1`
+ * and `dataType2`.
+ */
+ def checkConsistencyBetweenInterpretedAndCodegenAllowingException(
Review comment:
it seems to me that `checkConsistencyBetweenInterpretedAndCodegen` should
handle exceptions as well, as that's part of the consistency check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
