dongjoon-hyun commented on a change in pull request #25335: [SPARK-28601][CORE]
Use StandardCharsets.UTF_8 instead of "UTF-8" string representation
URL: https://github.com/apache/spark/pull/25335#discussion_r310183655
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQuerySuite.scala
##########
@@ -958,11 +959,11 @@ class StreamingQuerySuite extends StreamTest with
BeforeAndAfter with Logging wi
// Ideally we should copy "_spark_metadata" directly like what the user is
supposed to do to
// migrate to new version. However, in our test, "tempDir" will be
different in each run and
// we need to fix the absolute path in the metadata to match "tempDir".
- val sparkMetadata = FileUtils.readFileToString(new
File(legacySparkMetadataDir, "0"), "UTF-8")
+ val sparkMetadata = FileUtils.readFileToString(new
File(legacySparkMetadataDir, "0"),
+ StandardCharsets.UTF_8)
Review comment:
Shall we import `java.nio.charset.StandardCharsets.UTF_8` instead of
splitting this into two lines?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
