dongjoon-hyun commented on a change in pull request #25335: [SPARK-28601][CORE]
Use StandardCharsets.UTF_8 instead of "UTF-8" string representation
URL: https://github.com/apache/spark/pull/25335#discussion_r310184610
##########
File path:
sql/hive-thriftserver/v1.2.1/src/main/java/org/apache/hive/service/cli/operation/SQLOperation.java
##########
@@ -373,11 +374,7 @@ private RowSet decodeFromString(List<Object> rows, RowSet
rowSet)
int protocol = getProtocolVersion().getValue();
for (Object rowString : rows) {
- try {
- rowObj = serde.deserialize(new
BytesWritable(((String)rowString).getBytes("UTF-8")));
- } catch (UnsupportedEncodingException e) {
- throw new SerDeException(e);
- }
+ rowObj = serde.deserialize(new
BytesWritable(((String)rowString).getBytes(StandardCharsets.UTF_8)));
Review comment:
Nice change! Please mention this contribution in the PR title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
