dongjoon-hyun commented on a change in pull request #25335: [SPARK-28601][CORE]
Use StandardCharsets.UTF_8 instead of "UTF-8" string representation
URL: https://github.com/apache/spark/pull/25335#discussion_r310184369
##########
File path:
sql/hive-thriftserver/v1.2.1/src/main/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java
##########
@@ -69,16 +70,16 @@ private void setupSessionIO(SessionState sessionState) {
LOG.info("Putting temp output to file " +
sessionState.getTmpOutputFile().toString());
sessionState.in = null; // hive server's session input stream is not used
// open a per-session file in auto-flush mode for writing temp results
- sessionState.out = new PrintStream(new
FileOutputStream(sessionState.getTmpOutputFile()), true, "UTF-8");
+ sessionState.out = new PrintStream(new
FileOutputStream(sessionState.getTmpOutputFile()), true,
StandardCharsets.UTF_8.name());
Review comment:
ditto. Shall we import `java.nio.charset.StandardCharsets.UTF_8` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
