gengliangwang commented on a change in pull request #25369:
[SPARK-28638][WebUI] Task summary metrics are wrong when there are running tasks
URL: https://github.com/apache/spark/pull/25369#discussion_r311678525
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
##########
@@ -156,7 +162,8 @@ private[spark] class AppStatusStore(
// cheaper for disk stores (avoids deserialization).
val count = {
Utils.tryWithResource(
- if (store.isInstanceOf[InMemoryStore]) {
+ if (isInMemoryStore) {
Review comment:
@shahidki31 Thanks for the suggestion.
I am aware that #23088 is to follow the behavior of previous versions of
spark. But I wonder if we can simply show the summary metrics for all the
tasks instead of only the "SUCCESS" ones, as all the tasks are listed in the
task table. By doing that should also make sense to users. The implementation
will be simpler and we don't have to worry about the performance of the disk
store.
Also cc @vanzin @srowen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
