gengliangwang commented on a change in pull request #25369:
[SPARK-28638][WebUI] Task summary metrics are wrong when there are running tasks
URL: https://github.com/apache/spark/pull/25369#discussion_r311832281
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
##########
@@ -156,7 +162,8 @@ private[spark] class AppStatusStore(
// cheaper for disk stores (avoids deserialization).
val count = {
Utils.tryWithResource(
- if (store.isInstanceOf[InMemoryStore]) {
+ if (isInMemoryStore) {
Review comment:
@shahidki31 Do you mean #23088?
> as ExecutorRunTime will be defined for only finished tasks
That's not true. It is also defined in running tasks as I observed.
> reverting 23008 and hence this PR, would not fix the issue
I am not trying to revert anything. Just out of curiosity for the feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
