gengliangwang commented on a change in pull request #25369:
[SPARK-28638][WebUI] Task summary metrics are wrong when there are running tasks
URL: https://github.com/apache/spark/pull/25369#discussion_r312321931
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
##########
@@ -136,6 +136,8 @@ private[spark] class AppStatusStore(
store.read(classOf[StageDataWrapper], Array(stageId,
stageAttemptId)).locality
}
+ private def isInMemoryStore: Boolean = store.isInstanceOf[InMemoryStore] ||
listener.isDefined
Review comment:
I checked if it is live UI in the first commit.
As per the comment in
https://github.com/apache/spark/pull/23088/files#diff-3bd1667878f7bda9a56f95e93a80b475R233
and https://github.com/apache/spark/pull/25369#discussion_r311479709, I change
it to checking if it is InMemoryStore/Live UI.
But later on, I don't like the idea that live UI is inconsistent with SHS.
So I raise a question.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
