maropu commented on a change in pull request #25136: [SPARK-28322][SQL] Add
support to Decimal type for integral divide
URL: https://github.com/apache/spark/pull/25136#discussion_r312695976
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -394,25 +397,47 @@ case class Divide(left: Expression, right: Expression)
extends DivModLike {
// scalastyle:on line.size.limit
case class IntegralDivide(left: Expression, right: Expression) extends
DivModLike {
- override def inputType: AbstractDataType = IntegralType
+ override def inputType: AbstractDataType = TypeCollection(IntegralType,
DecimalType)
+
Review comment:
(This comment is not related to this pr though...) We need to update the
description for IntegralDivide:
https://github.com/apache/spark/pull/25136/files#diff-1516b10738479bbe190fb4e239258473R390
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
