maropu commented on a change in pull request #25136: [SPARK-28322][SQL] Add
support to Decimal type for integral divide
URL: https://github.com/apache/spark/pull/25136#discussion_r312696044
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
##########
@@ -292,6 +292,8 @@ case class Multiply(left: Expression, right: Expression)
extends BinaryArithmeti
// Common base trait for Divide and Remainder, since these two classes are
almost identical
trait DivModLike extends BinaryArithmetic {
+ def decimalToDataTypeCodeGen(decimalResult: String): String = decimalResult
Review comment:
protected?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
