gengliangwang commented on a change in pull request #25461:
[SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r314993133
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -494,7 +506,27 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
case DateType =>
buildCast[Int](_, d => null)
case TimestampType =>
- buildCast[Long](_, t => timestampToLong(t).toShort)
+ buildCast[Long](_, t => {
+ val longValue = timestampToLong(t)
+ if (!failOnIntegerOverflow || longValue == longValue.toShort) {
+ longValue.toShort
+ } else {
+ throw new ArithmeticException(s"Casting $t to Short causes
overflow.")
+ }
+ })
+ case x: NumericType if failOnIntegerOverflow =>
+ b =>
+ val intValue = try {
+ x.exactNumeric.asInstanceOf[Numeric[Any]].toInt(b)
Review comment:
Well, we can do it by match it case by case. Then the code is a bit long.
Casting to short/byte should be minor usage. Also, The previous code also cast
to `Int` before cast to `Short`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
