gengliangwang commented on a change in pull request #25461:
[SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r314994323
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1279,8 +1409,26 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
(c, evPrim, evNull) => code"$evNull = true;"
case TimestampType =>
(c, evPrim, evNull) => code"$evPrim = (long)
${timestampToIntegerCode(c)};"
+ case DecimalType() if failOnIntegerOverflow =>
+ (c, evPrim, evNull) =>
+ code"""
+ try {
+ $evPrim = $c.toJavaBigInteger().longValueExact();
+ } catch (ArithmeticException e) {
+ throw new ArithmeticException("Casting $c to Long causes
overflow");
+ }
+ """
case DecimalType() =>
(c, evPrim, evNull) => code"$evPrim = $c.toLong();"
+ case _: FloatType | _: DoubleType if failOnIntegerOverflow =>
+ (c, evPrim, evNull) =>
+ code"""
+ if ($c >= ${Long.MinValue}L && $c <= ${Long.MaxValue}L) {
Review comment:
I am not sure about that. Keeping the current behavior seems fine as well,
since we have printed the exact value which causes casting failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
