gengliangwang commented on a change in pull request #25461:
[SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r315760277
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/numerics.scala
##########
@@ -107,4 +109,85 @@ object LongExactNumeric extends LongIsIntegral with
Ordering.LongOrdering {
override def times(x: Long, y: Long): Long = Math.multiplyExact(x, y)
override def negate(x: Long): Long = Math.negateExact(x)
+
+ override def toInt(x: Long): Int =
+ if (x == x.toInt) {
+ x.toInt
+ } else {
+ throw new ArithmeticException(s"Casting $x to Int causes overflow.")
+ }
+}
+
+object FloatExactNumeric extends FloatIsFractional with Ordering.FloatOrdering
{
+ private def exceptionMessage(x: Float, dataType: String): String =
Review comment:
OK, I see. We can write it like this:
```
private def throwException(x: Float, dataType: String) =
throw new ArithmeticException(s"Casting $x to $dataType causes
overflow.")
```
We don't need to specify the returned type, which is `Nothing`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
