gengliangwang commented on a change in pull request #25461:
[SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r316709481
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1182,6 +1233,78 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
(c, evPrim, evNull) => code"$evPrim = $c != 0;"
}
+ private[this] def castTimestampToIntegerCode(
+ ctx: CodegenContext,
+ integralType: String): CastFunction = {
+ if (failOnIntegerOverflow) {
+ val longValue = ctx.freshName("longValue")
+ (c, evPrim, evNull) =>
+ code"""
+ long $longValue = ${timestampToLongCode(c)};
+ if ($longValue == ($integralType) $longValue) {
+ $evPrim = ($integralType) $longValue;
+ } else {
+ throw new ArithmeticException("Casting $c to $integralType causes
overflow");
+ }
+ """
+ } else {
+ (c, evPrim, evNull) => code"$evPrim = ($integralType)
${timestampToLongCode(c)};"
+ }
+ }
+
+ private[this] def castDecimalToIntegerCode(
+ ctx: CodegenContext,
+ integralType: String): CastFunction = {
+ (c, evPrim, evNull) => code"$evPrim =
$c.to${integralType.capitalize}($failOnIntegerOverflow);"
+ }
+
+ private[this] def castIntegerToIntegerExactCode(integralType: String):
CastFunction = {
+ assert(failOnIntegerOverflow)
+ (c, evPrim, evNull) =>
+ code"""
+ if ($c == ($integralType) $c) {
+ $evPrim = ($integralType) $c;
+ } else {
+ throw new ArithmeticException("Casting $c to $integralType causes
overflow");
+ }
+ """
+ }
+
+ private[this] def lowerAndUpperBound(
+ fractionType: String,
+ integralType: String): (String, String) = {
+ assert(fractionType == "float" || fractionType == "double")
+ val typeIndicator = fractionType.charAt(0)
+ val (min, max) = integralType.toLowerCase(Locale.ROOT) match {
Review comment:
Then it will be string "Int.MaxValue". Here I am trying to get string like
"2147483647f" , "2147483647d"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
