gengliangwang commented on a change in pull request #25461:
[SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r316925762
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
##########
@@ -232,12 +232,149 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
}
}
+ /**
+ * @return the Long value that is equal to the rounded decimal.
+ * @throws ArithmeticException if checkOverflow is true and
+ * the decimal too big to fit in Long type.
+ */
+ def toLong(checkOverflow: Boolean): Long = {
Review comment:
BTW, renaming to `toLongExact` won't accurate either. For example,
`toLongExact(1.1)` should be false, while we are actually doing rounding in
toLong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
