gengliangwang commented on a change in pull request #25461:
[SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r316711648
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1182,6 +1233,78 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
(c, evPrim, evNull) => code"$evPrim = $c != 0;"
}
+ private[this] def castTimestampToIntegerCode(
Review comment:
`Integral` is adjective. "Integral code" seems weird to me.
We can call it `castTimestampToIntegralTypeCode` if you insist. I didn't use
it because the name is a bit long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
