Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/4183#issuecomment-71276246
I agree that vectors must have the same length and we should check it. It
may not be necessary to change the implementation. I saw couple performance
issues in your code. For example, unnecessary index lookups. I would suggest
only adding the check in this PR. If you want to update the implementation,
let's do it in another PR with micro-benchmark.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
