Github user hhbyyh commented on the pull request:
https://github.com/apache/spark/pull/4183#issuecomment-71301889
Thank for the reply, Iâll limit the scope. And since the size equality
constraint will be pretty straight-forward, it seems no additional ut is
required.
The main purpose for the code refactoring was to unify the scattered logic.
Performance wise, the only concern for the original code was the extra
space consumption for,
1. the invocation of `SparseVector.toArray` when v1.indices.length /
v1.size >= 0.5,
2. the zip action in (dense, dense) computation.
I'll hold the refactoring until it's found necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
