Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/4183#issuecomment-71418817
LGTM. Merged into master. For the performance issue, let's open another PR
for it. I can see at least the condition "v1.indices.length / v1.size < 0.5" is
wrong, because the left-hand side returns an integer. Please let me know
whether you want to continue working on this. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
