HeartSaVioR commented on a change in pull request #25923:
[DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in
Jenkins
URL: https://github.com/apache/spark/pull/25923#discussion_r327918679
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -448,7 +448,12 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
listFilesRecursively(new File(inputFilePath)).flatMap { file =>
val resultFile = file.getAbsolutePath.replace(inputFilePath,
goldenFilePath) + ".out"
val absPath = file.getAbsolutePath
+
+ // Replacing '.' to '_' is an workaround of sbt bug which removes test
name prior to the
+ // last dot in JUnitXmlReportPlugin.
+ // Please refer https://github.com/sbt/sbt/issues/2949
val testCaseName =
absPath.stripPrefix(inputFilePath).stripPrefix(File.separator)
+ .replace('.', '_')
Review comment:
Ah I just saw your comments after commenting. Yeah it's ideal if sbt fixes
the issue but looks like they don't mind.
IMHO we should apply the workaround for now if we create dynamic tests which
end up with same name like here. We may not want to address all the occurrence
(like single test having '.') as it's still trackable but this case they're all
marked as `sql` and not trackable in Jenkins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
