HeartSaVioR commented on a change in pull request #25923:
[DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in
Jenkins
URL: https://github.com/apache/spark/pull/25923#discussion_r328800368
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -49,7 +50,7 @@ import org.apache.spark.tags.ExtendedSQLTest
*
* To run a single test file upon change:
* {{{
- * build/sbt "~sql/test-only *SQLQueryTestSuite -- -z inline-table.sql"
Review comment:
> I don't think many people actually know build/sbt "~sql/test-only
*SQLQueryTestSuite -- -z xxx.sql" is based upon its test name
I'm not sure I could agree with this, as that means this feature is blindly
used at all which it shouldn't (as it only applies to `*SQLQueryTestSuite`).
This is even documented in Spark website. Please refer "Testing with SBT" in
http://spark.apache.org/developer-tools.html
> matching it to the exact file name is pretty good one.
Yes I totally agree it is more intuitive and better. So that's "trade-off".
Test history of *SQLQueryTestSuite in Jenkins is just unusable as of now, so
personally I think it's worth to weigh on both. Not a strong opinion as I
commented before - it's just a proposal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
