HeartSaVioR commented on a change in pull request #25923:
[DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in
Jenkins
URL: https://github.com/apache/spark/pull/25923#discussion_r328081225
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -49,7 +50,7 @@ import org.apache.spark.tags.ExtendedSQLTest
*
* To run a single test file upon change:
* {{{
- * build/sbt "~sql/test-only *SQLQueryTestSuite -- -z inline-table.sql"
Review comment:
Huge win of this workaround is availability of looking into history of
individual test. It would provide context which cannot be retrieve from test
log, which is really helpful to track down test flakiness.
e.g.
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111332/testReport/org.apache.spark.sql/SQLQueryTestSuite/typeCoercion_native_mapconcat/history/
Full tests in SQLQueryTestSuite:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111332/testReport/org.apache.spark.sql/SQLQueryTestSuite/
Full tests in ThriftServerQueryTestSuite (same test can be matched with
SQLQueryTestSuite):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111332/testReport/org.apache.spark.sql.hive.thriftserver/ThriftServerQueryTestSuite/
So I'm afraid I'm not sure it's just only cosmetic issue. This workaround
brings actual benefits, though it has pros and cons, unfortunately. I guess
someone would be familiar with file path instead of file path excluding ".sql",
so please treat this as a proposal and weigh on current state vs "workaround
applied" state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
