Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4294#discussion_r23943539
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api.scala ---
    @@ -171,6 +171,27 @@ private[sql] trait DataFrameSpecificApi {
       def saveAsTable(tableName: String): Unit
     
       @Experimental
    +  def saveAsTable(tableName: String, dataSourceName: String, options: 
Map[String, String]): Unit
    --- End diff --
    
    When we add the short hand version that only takes a table name, we need to 
make sure that we set the `EXTERNAL` property correctly so that `DROP TABLE` 
will operate as users expect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to