MaxGekk commented on a change in pull request #26134: [SPARK-29486][SQL]
CalendarInterval should have 3 fields: months, days and microseconds
URL: https://github.com/apache/spark/pull/26134#discussion_r335353374
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
##########
@@ -365,12 +368,12 @@ public boolean equals(Object other) {
if (other == null || !(other instanceof CalendarInterval)) return false;
CalendarInterval o = (CalendarInterval) other;
- return this.months == o.months && this.microseconds == o.microseconds;
+ return this.months == o.months && this.days == o.days && this.microseconds
== o.microseconds;
}
@Override
public int hashCode() {
- return 31 * months + (int) microseconds;
+ return 31 * (31 * months + days) + (int) microseconds;
Review comment:
Not related to the PR but I am wondering why the most significant bits of
microseconds are completely excluded from the hash.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
