cloud-fan commented on a change in pull request #26465: [SPARK-29390][SQL] Add
the justify_days(), justify_hours() and justif_interval() functions
URL: https://github.com/apache/spark/pull/26465#discussion_r345051327
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala
##########
@@ -257,3 +257,69 @@ case class MakeInterval(
override def prettyName: String = "make_interval"
}
+
+abstract class IntervalJustifyLike(
+ child: Expression,
+ justify: CalendarInterval => CalendarInterval,
+ justifyType: String) extends UnaryExpression with ExpectsInputTypes {
Review comment:
nit: it's clearer to pass in `justifyFuncName: String`
```
extends IntervalJustifyLike(child, justifyHours, "justifyHours")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
