cloud-fan commented on a change in pull request #26465: [SPARK-29390][SQL] Add
the justify_days(), justify_hours() and justif_interval() functions
URL: https://github.com/apache/spark/pull/26465#discussion_r345313968
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -637,4 +637,40 @@ object IntervalUtils {
new CalendarInterval(totalMonths, totalDays, micros)
}
+
+ /**
+ * Adjust interval so 30-day time periods are represented as months
+ */
+ def justifyDays(interval: CalendarInterval): CalendarInterval = {
+ val monthToDays = interval.months * DAYS_PER_MONTH
+ val totalDays = Math.addExact(monthToDays, interval.days)
+ val months = Math.toIntExact(totalDays / DAYS_PER_MONTH)
+ val days = Math.toIntExact(totalDays % DAYS_PER_MONTH)
Review comment:
ditto, the value is less than 30 and can never overflow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
