cloud-fan commented on a change in pull request #26465: [SPARK-29390][SQL] Add the justify_days(), justify_hours() and justif_interval() functions URL: https://github.com/apache/spark/pull/26465#discussion_r345251773
########## File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/interval.sql ########## @@ -342,3 +333,11 @@ SELECT interval '1 2:03:04' minute to second; -- select make_interval(secs := 'inf'); -- select make_interval(secs := 'NaN'); -- select make_interval(secs := 7e12); + +-- test justify_hours() and justify_days() +-- [SPARK-29390] Add the justify_days(), justify_hours() and justify_interval() functions Review comment: I don't get it. This is a TODO and now it's done. Why still keep it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
