Github user florianverhein commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4385#discussion_r24218680
  
    --- Diff: ec2/spark_ec2.py ---
    @@ -330,7 +338,10 @@ def get_spark_ami(opts):
             print >> stderr,\
                 "Don't recognize %s, assuming type is pvm" % opts.instance_type
     
    -    ami_path = "%s/%s/%s" % (AMI_PREFIX, opts.region, instance_type)
    +    # URL prefix from which to fetch AMI information
    +    ami_prefix = 
"{r}/{b}/ami-list".format(r=opts.spark_ec2_git_repo.replace("github","raw.github"),
 b=opts.spark_ec2_branch)
    --- End diff --
    
    Good point. 
    replace doesn't seem to support regexes, so to keep things simple I matched 
like you suggested, and limited to 1 match


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to