Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4385#discussion_r24219900
--- Diff: ec2/spark_ec2.py ---
@@ -643,12 +654,14 @@ def setup_cluster(conn, master_nodes, slave_nodes,
opts, deploy_ssh_key):
# NOTE: We should clone the repository before running deploy_files to
# prevent ec2-variables.sh from being overwritten
+ repo_branch="{r} -b {b}".format(r=opts.spark_ec2_git_repo,
b=opts.spark_ec2_branch)
+ print "Cloning spark-ec2 scripts from {rb} on
master...".format(rb=repo_branch)
ssh(
host=master,
opts=opts,
command="rm -rf spark-ec2"
+ " && "
- + "git clone https://github.com/mesos/spark-ec2.git -b
{b}".format(b=MESOS_SPARK_EC2_BRANCH)
+ + "git clone {rb}".format(rb=repo_branch)
--- End diff --
I think we need to change this to always clone to `spark-ec2`.
Otherwise, if people fork `spark-ec2` to something with a different name,
the cloned repo will have a random name and stuff will break like the `rm -rf`
command a few lines up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
