Github user nchammas commented on a diff in the pull request: https://github.com/apache/spark/pull/4385#discussion_r24219625 --- Diff: ec2/spark_ec2.py --- @@ -145,6 +145,14 @@ def parse_args(): default=DEFAULT_SPARK_GITHUB_REPO, help="Github repo from which to checkout supplied commit hash (default: %default)") parser.add_option( + "--spark-ec2-git-repo", + default=DEFAULT_SPARK_EC2_GITHUB_REPO, + help="Github repo from which to checkout spark-ec2 (default: %default)") + parser.add_option( + "--spark-ec2-branch", + default=DEFAULT_SPARK_EC2_BRANCH, + help="spark-ec2 branch to use (default: %default)") --- End diff -- Another super nit here: Is it a spark-ec2 branch or a GitHub repo branch?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org