normanmaurer commented on issue #26609: [SPARK-29971] Fix multiple possible buffer leaks in `TransportFrameDecoder/TransportCipher` URL: https://github.com/apache/spark/pull/26609#issuecomment-557030152 @vanzin like mentioned above I am not sure it is safe to assume it always consume all data as an `InternalError` may be thrown (you even guard against it). So I would suggest to be better safe then sorry. If you are super concerned about the extra logic in `feedData(...)` I would also be happy to let it throw if we already have a reference to a `ByteBuf`. Just let me know if you would prefer this and I will change the code. That said I am not sure why it is such a big deal to add the code to `feedData` as I did as I don't think it is overly complex. But I am happy to adapt if needed :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
