normanmaurer commented on issue #26609: [SPARK-29971] Fix multiple possible buffer leaks in `TransportFrameDecoder/TransportCipher` URL: https://github.com/apache/spark/pull/26609#issuecomment-557206321 @vanzin yes we could also just remove all the `release` magic in `ByteArrayReadableChannel.read(...)` and `close(...)` and handle all in `channelRead(...)` that would be fine with me as well. When I started the patch my assumption was that `ByteArrayReadableChannel` may be used by users and so we should not do this because of this. If this not a problem then sure lets do it. Please let me know.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
