normanmaurer commented on issue #26609: [SPARK-29971] Fix multiple possible buffer leaks in `TransportFrameDecoder/TransportCipher` URL: https://github.com/apache/spark/pull/26609#issuecomment-557202373 @vanzin I am not talking about the changes in `feedData(...)` here (which I think we can also just let it throw an exception as stated above). I am saying that if we not release the buffer in `close()` we may leak as there is no guarantee that we consume the whole buffer and so release it if an `InternalError` was thrown.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
