sarutak commented on a change in pull request #26637: [SPARK-29997][WEBUI] Show
job name for empty jobs in WebUI
URL: https://github.com/apache/spark/pull/26637#discussion_r350011453
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala
##########
@@ -414,7 +414,7 @@ private[spark] class AppStatusListener(
val e = it.next()
if (job.stageIds.contains(e.getKey()._1)) {
val stage = e.getValue()
- if (v1.StageStatus.PENDING.equals(stage.status)) {
+ if (v1.StageStatus.PENDING.equals(stage.status) &&
stage.info.numTasks > 0) {
Review comment:
Changes in this PR is to care the case when a job has 1 or more partitions
(tasks).
So, I think that `numTasks > 0` makes sense rather than `stageId != -1` .
Or how about making the `while` loop containing this code block like `while
(job.stageIds.nonEmpty && it.hasNext())`
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
