sarutak commented on a change in pull request #26637: [SPARK-29997][WEBUI] Show
job name for empty jobs in WebUI
URL: https://github.com/apache/spark/pull/26637#discussion_r350603114
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
##########
@@ -629,7 +629,9 @@ private[ui] class JobPagedTable(
</td>
<td>{jobTableRow.formattedDuration}</td>
<td class="stage-progress-cell">
- {job.numCompletedStages}/{job.stageIds.size - job.numSkippedStages}
+ {job.numCompletedStages}/{
+ if (job.numTasks > 0) job.stageIds.size - job.numSkippedStages else 0
Review comment:
I withdraw my statement above. This change is still needed.
A job which has no partitions has at least 1 stage and the stage should not
marked as skipped.
So, if we don't have this change, we'll see following result.
<img width="1426" alt="スクリーンショット 2019-11-26 17 42 32"
src="https://user-images.githubusercontent.com/4736016/69613283-ac3ab200-1074-11ea-90d9-d08b14e22fe0.png";>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/4736016/69613283-ac3ab200-1074-11ea-90d9-d08b14e22fe0.png"](https://user-images.githubusercontent.com/4736016/69613283-ac3ab200-1074-11ea-90d9-d08b14e22fe0.png"){kind=link}