tdas commented on a change in pull request #26771: [SPARK-30143][SS] Add a 
timeout on stopping a streaming query
URL: https://github.com/apache/spark/pull/26771#discussion_r356479875
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
 ##########
 @@ -240,8 +241,16 @@ final class DataStreamWriter[T] private[sql](ds: 
Dataset[T]) {
    * path as new data arrives. The returned [[StreamingQuery]] object can be 
used to interact with
    * the stream.
    *
+   * @throws TimeoutException If another run of the same streaming query (a 
streaming query sharing
+   *                          the same checkpoint location) is already active 
on the same Spark
+   *                          cluster, the SQL configuration
+   *                          `spark.sql.streaming.stopActiveRunOnRestart` is 
enabled, and the
+   *                          active run cannot be stopped within the timeout 
controlled by the
+   *                          SQL configuration, we throw a TimeoutException.
 
 Review comment:
   nit: this is hard to read. You can flip and make it a bulleted list.
   ```
   A timeout exception will be thrown if the following conditions are met: 
   - Another run of the same ...
   - The SQL configuration. ...
   - This active run cannot be stopped without  ....
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to