tdas commented on a change in pull request #26771: [SPARK-30143][SS] Add a timeout on stopping a streaming query URL: https://github.com/apache/spark/pull/26771#discussion_r356482672
########## File path: sql/core/src/test/scala/org/apache/spark/sql/streaming/util/BlockOnStopSource.scala ########## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.streaming.util + +import java.util +import java.util.concurrent.CountDownLatch + +import scala.collection.JavaConverters._ + +import org.apache.zookeeper.KeeperException.UnimplementedException + +import org.apache.spark.sql.{DataFrame, Row, SparkSession, SQLContext} +import org.apache.spark.sql.connector.catalog.{SupportsRead, Table, TableCapability, TableProvider} +import org.apache.spark.sql.connector.catalog.TableCapability.CONTINUOUS_READ +import org.apache.spark.sql.connector.read.{streaming, InputPartition, Scan, ScanBuilder} +import org.apache.spark.sql.connector.read.streaming.{ContinuousPartitionReaderFactory, ContinuousStream, PartitionOffset} +import org.apache.spark.sql.execution.streaming.{LongOffset, Offset, Source} +import org.apache.spark.sql.sources.StreamSourceProvider +import org.apache.spark.sql.types.{LongType, StructType} +import org.apache.spark.sql.util.CaseInsensitiveStringMap + +/** The V1 and V2 provider of a streaming source, which blocks indefinitely on the call of stop() */ +object BlockOnStopSourceProvider extends StreamSourceProvider with TableProvider { + + private var _latch: CountDownLatch = _ + + val schema: StructType = new StructType().add("id", LongType) + + /** Set the latch that we will use to block the streaming query thread. */ + def setLatch(latch: CountDownLatch): Unit = { Review comment: nit: more meaningful to read if there is a semantic meaning to the name ... like `enableBlocking` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
