tdas commented on a change in pull request #26771: [SPARK-30143][SS] Add a
timeout on stopping a streaming query
URL: https://github.com/apache/spark/pull/26771#discussion_r356480893
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQuery.scala
##########
@@ -142,10 +143,19 @@ trait StreamingQuery {
def processAllAvailable(): Unit
/**
- * Stops the execution of this query if it is running. This method blocks
until the threads
- * performing execution has stopped.
+ * Stops the execution of this query if it is running. This awaits the
termination of the query
Review comment:
super nit: `This waits until the termination ... or until a timeout ....`
The parallel structure is weird in the current form.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]