HeartSaVioR commented on a change in pull request #26821:
[SPARK-20656][CORE]Support Incremental parsing of event logs in SHS
URL: https://github.com/apache/spark/pull/26821#discussion_r356987566
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -411,19 +418,22 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
val uiOption = synchronized {
activeUIs.remove((appId, attemptId))
}
- uiOption.foreach { loadedUI =>
- loadedUI.lock.writeLock().lock()
- try {
- loadedUI.ui.store.close()
- } finally {
- loadedUI.lock.writeLock().unlock()
- }
+ // If incremental parsing is enabled, will not close the underlying store.
Review comment:
Looks redundant as we explained it already in above. Either one would be
sufficient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
