HeartSaVioR commented on a change in pull request #26821: 
[SPARK-20656][CORE]Support Incremental parsing of event logs in SHS
URL: https://github.com/apache/spark/pull/26821#discussion_r357033262
 
 

 ##########
 File path: 
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
 ##########
 @@ -190,6 +191,54 @@ class FsHistoryProviderSuite extends SparkFunSuite with 
Matchers with Logging {
     provider.mergeApplicationListingCall should be (1)
   }
 
+  test("support incremental parsing of the event logs") {
 
 Review comment:
   I know most of tests in FsHistoryProviderSuite don't deal with rolling event 
log, but this should really deal with it, as it's not just simple sequential 
reading of files.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to