HeartSaVioR commented on a change in pull request #26821:
[SPARK-20656][CORE]Support Incremental parsing of event logs in SHS
URL: https://github.com/apache/spark/pull/26821#discussion_r356989341
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -615,10 +625,20 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
}
maybeUI.foreach { ui =>
+ if (isIncrementalParsingEnabled) {
+ storeMap.remove(appId -> attemptId)
+ }
ui.invalidate()
ui.ui.store.close()
}
+ if (isIncrementalParsingEnabled) {
Review comment:
I don't see a reason to maintain metadata of reading in kvstore, given we
lose everything upon SHS restart. You may want to store it in another HashMap,
or even simply just store it within storeMap. (You may want to have another
class for data structure of storeMap entity.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
