cloud-fan commented on a change in pull request #26847: [SPARK-30214][SQL] A
new framework to resolve v2 commands
URL: https://github.com/apache/spark/pull/26847#discussion_r361612753
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -720,6 +740,30 @@ class Analyzer(
}
}
+ case class ResolveCatalogAndNamespace(catalogManager: CatalogManager)
+ extends Rule[LogicalPlan] with LookupCatalog {
+ def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
+ case UnresolvedNamespace(CatalogAndNamespace(catalog, ns)) =>
+ ResolvedNamespace(catalog.asNamespaceCatalog, ns)
+ }
+ }
+
+ case class ResolveCatalogAndTable(catalogManager: CatalogManager)
Review comment:
instead of creating a new rule, can we just catch `UnresolvedTable` in
`ResolveTables` and `ResolveRelations`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
