cloud-fan commented on a change in pull request #26847: [SPARK-30214][SQL] A
new framework to resolve v2 commands
URL: https://github.com/apache/spark/pull/26847#discussion_r361613520
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -210,6 +212,19 @@ object DataSourceV2Strategy extends Strategy with
PredicateHelper {
case AlterNamespaceSetProperties(catalog, namespace, properties) =>
AlterNamespaceSetPropertiesExec(catalog, namespace, properties) :: Nil
+ case CommentOnNamespace(ResolvedNamespace(catalog, namespace), comment) =>
Review comment:
After some more thoughts, I think it's true that empty string comment is the
same as no comment w.r.t. DESCRIBE command. But it's different to catalog
developers who can access the properties directly. I think it's better to
remove the comment property if the comment string is empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
