cloud-fan commented on a change in pull request #26847: [SPARK-30214][SQL] A
new framework to resolve v2 commands
URL: https://github.com/apache/spark/pull/26847#discussion_r361634767
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -1929,6 +1929,73 @@ class DataSourceV2SQLSuite
}
}
+ test("COMMENT ON NAMESPACE") {
+ // unset this config to use the default v2 session catalog.
+ spark.conf.unset(V2_SESSION_CATALOG_IMPLEMENTATION.key)
+ // Session catalog is used.
+ sql(s"CREATE NAMESPACE ns")
+ checkNamespaceComment("ns", "minor revision")
+ checkNamespaceComment("ns", null)
+ checkNamespaceComment("ns", "NULL")
+ intercept[AnalysisException](sql(s"COMMENT ON NAMESPACE abc IS NULL"))
+
+ // V2 non-session catalog is used.
+ sql(s"CREATE NAMESPACE testcat.ns1")
+ checkNamespaceComment("testcat.ns1", "minor revision")
+ checkNamespaceComment("testcat.ns1", null)
+ checkNamespaceComment("testcat.ns1", "NULL")
+ intercept[AnalysisException](sql(s"COMMENT ON NAMESPACE abc.xyz IS NULL"))
Review comment:
nit: `abc.xyz` -> `testcat.abc`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
