yangwwei commented on a change in pull request #277:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/277#discussion_r690879678
##########
File path: pkg/cache/application.go
##########
@@ -58,6 +58,7 @@ type Application struct {
placeholderAsk *si.Resource // total placeholder request
for the app (all task groups)
placeholderTimeoutInSec int64
schedulingStyle string
+ requestOriginatingPod *v1.Pod // Original Pod which creates the
requests
Review comment:
This is strange. I understand the intention was to add some pod events
to expose that placeholder times out; however, sending this event whenever we
delete a placeholder to the first pod of the app is strange...
if we have an app CRD, that might be a better place to gather the event; but
today we do not have that. I suggest to just print some logs for now. unless
there is a better place to expose such messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
