wilfred-s commented on a change in pull request #277:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/277#discussion_r692678326
##########
File path: pkg/cache/application.go
##########
@@ -58,6 +58,7 @@ type Application struct {
placeholderAsk *si.Resource // total placeholder request
for the app (all task groups)
placeholderTimeoutInSec int64
schedulingStyle string
+ requestOriginatingPod *v1.Pod // Original Pod which creates the
requests
Review comment:
I do not think you have read the code correctly. See the code in
`publishPlaceholderTimeoutEvents()`
The event is only written to the first pod if the pod that is finished is a
placeholder and the TerminationType is a timeout. That means it will only
happen for placeholders that were requested but not replaced. If and when you
get the app CRD for all that can be easily changed to be set on the CRD.
For gang scheduling the first pod contains the annotations. It will always
be set as the originating pod for the app. Placeholder timeouts will thus be
linked to the pod with the annotations.
I don't think we have made this a generic any finished pod to a random pod
kind of setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
