wilfred-s commented on a change in pull request #277:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/277#discussion_r694597790
##########
File path: pkg/cache/application.go
##########
@@ -58,6 +58,7 @@ type Application struct {
placeholderAsk *si.Resource // total placeholder request
for the app (all task groups)
placeholderTimeoutInSec int64
schedulingStyle string
+ requestOriginatingPod *v1.Pod // Original Pod which creates the
requests
Review comment:
I would say it does help. Even if they get annoyed by the fact that
there are a lot of events it tells them that they need to look at their gang
request. Something is wrong if there are lots of time out messages. Either with
their request or the app or the cluster.
If we have the possibility to update the CRD then we can do that. If we do
not have that possibility now then that is not an option. We also need to
handle the case that we have a gang scheduling request that does not use the
operator. In that case the only reasonable way to tell the user that the
placeholders are timing out is via the driver pod.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
